chore(arc-tf): drop ineffective listener-resource workarounds#27
Merged
Conversation
Revert PR #26's additions: ServerSideApply=true and the Role/RoleBinding ignoreDifferences entries. Neither addressed the OutOfSync state — that turns out to be ArgoCD's label-based tracking claiming controller-created listener resources that the chart never renders, which is structurally not solvable via field-level ignore patterns. Comment notes the condition is cosmetic; Health stays correct. Also drop the AutoscalingListener ignoreDifferences entry since the chart doesn't render that kind, so there's no desired state to drift from. Keep only the AutoscalingRunnerSet entry, which IS chart-rendered and does see controller-driven annotation churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert the additions from #26 — they didn't actually resolve the OutOfSync state, which structurally needs a cluster-wide `resourceTrackingMethod` change to fix and is functionally cosmetic. Keep only the AutoscalingRunnerSet `ignoreDifferences` entry that prevents selfHeal from thrashing on controller-driven annotation churn.
Removed (from #26)
Removed (cleanup, was originally added in #25)
Kept
Comment in the manifest now documents the cosmetic OutOfSync as accepted.
🤖 Generated with Claude Code